Relax overly strict asserts in dependency queue

Don't actually need to assert that these are unique, it works both ways and we
can have flavorful dependency graphs which otherwise trigger the assertions.

Closes #3902

diff --git a/src/cargo/util/dependency_queue.rs b/src/cargo/util/dependency_queue.rs
index 1514585d960db6e1915c7b4ea5cfb7cbb0675251..1b054428b6565cd542a6ff2332fd21ac3e30229f 100644 (file)
--- a/src/cargo/util/dependency_queue.rs
+++ b/src/cargo/util/dependency_queue.rs
@@ -83,10 +83,10 @@ impl<K: Hash + Eq + Clone, V> DependencyQueue<K, V> {
 
         let mut my_dependencies = HashSet::new();
         for dep in dependencies {
-            assert!(my_dependencies.insert(dep.clone()));
+            my_dependencies.insert(dep.clone());
             let rev = self.reverse_dep_map.entry(dep.clone())
                                           .or_insert_with(HashSet::new);
-            assert!(rev.insert(key.clone()));
+            rev.insert(key.clone());
         }
         &mut slot.insert((my_dependencies, value)).1
     }

diff --git a/tests/test.rs b/tests/test.rs
index 94ac33a0095cc53af42d86fd32aeb993aa2a6ba7..fbbf02667e19a9b232f284f065795d4d23ea803b 100644 (file)
--- a/tests/test.rs
+++ b/tests/test.rs
@@ -3005,3 +3005,25 @@ test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured
 "));
 
 }
+
+#[test]
+fn cyclic_dev() {
+   let p = project("foo")
+        .file("Cargo.toml", r#"
+            [project]
+            name = "foo"
+            version = "0.1.0"
+
+            [dev-dependencies]
+            foo = { path = "." }
+        "#)
+        .file("src/lib.rs", r#"
+            #[test] fn test_lib() {}
+        "#)
+        .file("tests/foo.rs", r#"
+            extern crate foo;
+        "#);
+
+    assert_that(p.cargo_process("test").arg("--all"),
+                execs().with_status(0));
+}